Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eth-lattice-keyring to v0.12.3 #15997

Merged
merged 4 commits into from
Oct 4, 2022
Merged

Update eth-lattice-keyring to v0.12.3 #15997

merged 4 commits into from
Oct 4, 2022

Conversation

adonesky1
Copy link
Contributor

Changes + description copied from PR opened by Gridplus team here:

  • Updates @ethereumjs/util to v8.0.0 to reduce bundle size
  • Removes secp256k1 and @ethereumjs/common to reduce bundle size
  • Updates gridplus-sdk to v2.2.9
    • Adds caching for calls to block explorers to improve UX (PR)

@adonesky1 adonesky1 requested a review from a team as a code owner September 27, 2022 15:56
@adonesky1 adonesky1 requested a review from NidhiKJha September 27, 2022 15:56
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@adonesky1 adonesky1 force-pushed the bump-eth-lattice-keyring-version branch from 11bcf17 to 282487f Compare September 27, 2022 15:57
@socket-security
Copy link

socket-security bot commented Sep 27, 2022 •
edited
Loading

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (upgraded) postinstall package.json via [email protected]
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 1 new install script detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ✅ no new native modules
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@adonesky1 adonesky1 force-pushed the bump-eth-lattice-keyring-version branch from 282487f to 5352ca3 Compare September 27, 2022 16:05
@adonesky1
Copy link
Contributor Author

the post-install field that socket-security is calling out is not newly added in the version we're bumping to.

@metamaskbot
Copy link
Collaborator

Builds ready [da7ea27]
Page Load Metrics (2483 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002325230481231
domContentLoaded21972770245016780
load21972797248317986
domInteractive21972770245016780

@adonesky1 adonesky1 force-pushed the bump-eth-lattice-keyring-version branch from da7ea27 to 87200ee Compare September 29, 2022 17:42
@metamaskbot
Copy link
Collaborator

Builds ready [51a847f]
Page Load Metrics (2446 ± 98 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932596254540259
domContentLoaded195929242426217104
load19592925244620598
domInteractive195929242426217104

@PeterYinusa
Copy link
Contributor

LGTM

@metamaskbot
Copy link
Collaborator

Builds ready [09362e3]
Page Load Metrics (2458 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951991352713
domContentLoaded193528222428215103
load20112822245819995
domInteractive193528222428215103

NiranjanaBinoy
NiranjanaBinoy approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adonesky1 adonesky1 merged commit 3b63ecf into develop Oct 4, 2022
@adonesky1 adonesky1 deleted the bump-eth-lattice-keyring-version branch October 4, 2022 00:02
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PeterYinusa PeterYinusa PeterYinusa approved these changes

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy approved these changes

@NidhiKJha NidhiKJha Awaiting requested review from NidhiKJha NidhiKJha is a code owner automatically assigned from MetaMask/extension-devs

@brad-decker brad-decker Awaiting requested review from brad-decker

@danjm danjm Awaiting requested review from danjm

@darkwing darkwing Awaiting requested review from darkwing

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adonesky1 @metamaskbot @PeterYinusa @NiranjanaBinoy @seaona